This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] Add missing iprintf and iscanf family for SPU
Patrick Mansfield <patmans@us.ibm.com> wrote:
> On Mon, Feb 19, 2007 at 12:22:23PM +0900, Kazunori Asayama wrote:
> > Patrick Mansfield <patmans@us.ibm.com> wrote:
> > Here is an alternative approach:
> >
> > - to eliminate internal use of iprintf family, and
> > - to leave iprintf family undefined.
> > (or to define iprintf family as functions if required.)
> >
> > Attached is a patch to implement this.
> > What do you think ?
>
> That still leaves the (potentially) conflicting prototypes for the
> iprintf's in stdio.h. I don't like the double negative ("#ifndef ifndef
> NO_INTERNAL_IPRINTF") but since SPU is the exception, I guess it is OK
> (versus having INTERNAL_IPRINTF defined for most archs, and then
> undefining it for SPU).
If we don't prefer to declare non-standard functions such as iprintf
family (i.e. newlib specific extensions) in public headers, I suppose
that we should use __STRICT_ANSI__ to hide them rather than a special
macro NO_INTERNAL_IPRINTF. Otherwise, the same problem will come up
again when iprintf family for SPU become available...
--
(ASAYAMA Kazunori
(asayama@sm.sony.co.jp))
t