This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] fix printf("%p") (lesstif / XPDF crash)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Brian Dessent on 5/27/2007 7:01 AM:
> Currently sprintf("%p") does not work because the path taken for
> handling %p shares most of the code with %x but fails to populate the
> char ox[2] used to emit the prefix, resulting in two uninitialized
> characters being written instead of 'Ox'.

Sorry about that - I missed %p when I changed the logic of %x in order to
add %a.  But your analysis is correct, and your patch looks correct too.
Since I broke it, I'm checking in your patch as obvious.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             ebb9@byu.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGWZJ784KuGfSFAYARAryeAKCFjOeRgPJiRRBFvLGn9VtaZbU5rgCffhd2
MtNZ4klT+iYslPeSCTbHoWg=
=xLxx
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]