Re: [patch] Add wcstol, wcstoul, wcstoll, wcstoull

[Corinna Vinschen <vinschen at redhat dot com>]

On Jul  6 13:06, Jeff Johnston wrote:
> Please go ahead.
> 
> -- Jeff J.
> 
> Corinna Vinschen wrote:
> >This adds the missing wide char to integer conversion functions.  I
> >created them from their single-byte character counterparts.  I also
> >tried to convert strtod to wcstod, but stopped midway since that would
> >have also required to create wide char functions of the helper routines
> >in mprec.h and gdtoa-gethex.c.
> >
> >I also changed the man page entries in strtoll.c and strtoull.c.  The
> >still claimed that these functions are non-standard, which isn't correct
> >anymore.  All of these functions, including the wcstoxxx functions are
> >POSIX standard functions referrencing the ISO C standard.
> >
> >
> >Ok to apply?
> >
> >
> >Corinna
> >
> >
> >	* libc/include/wchar.h: Declare wcstol, wcstoll, wcstoul,
> >	wcstoull, _wcstol_r, _wcstoll_r, _wcstoul_r and _wcstoull_r.
> >	* libc/stdlib/Makefile.am (GENERAL_SOURCES): Add wcstol.c and 
> >	wcstoul.c.
> >	(EXTENDED_SOURCES): Add wcstoll.c, wcstoll_r.c, wcstoull.c and
> >	wcstoull_r.c.
> >	(CHEWOUT_FILES): Add .def files accordingly.
> >	* libc/stdlib/Makefile.in: Regenerate.
> >	* libc/stdlib/stdlib.tex: Add documentation links for above 
> >	functions.
> >	* libc/stdlib/strtoll.c: Fix portability note.
> >	* libc/stdlib/strtoull.c: Ditto.
> >	* libc/stdlib/wcstol.c: New file.
> >	* libc/stdlib/wcstoll.c: New file.
> >	* libc/stdlib/wcstoll_r.c: New file.
> >	* libc/stdlib/wcstoul.c: New file.
> >	* libc/stdlib/wcstoull.c: New file.
> >	* libc/stdlib/wcstoull_r.c: New file.

Thanks, applied.

Any idea how we could implement wcstof, wcstod and wcstold without
too much overhead?


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat