This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch] Fix bug in ARM big-endian strcpy assembly implementation.


This patch fixes a typo in the assembly code in machine/arm/strcpy.c
that only shows up when __ARMEB__ is defined.

-----------------------------------------------------------------
2009-02-26  Brooks Moses  <brooks@codesourcery.com>

	* libc/machine/arm/strcpy.c: Add missing comma.

-----------------------------------------------------------------

Thanks!
- Brooks
Index: newlib/libc/machine/arm/strcpy.c
===================================================================
--- newlib/libc/machine/arm/strcpy.c	(revision 237836)
+++ newlib/libc/machine/arm/strcpy.c	(working copy)
@@ -92,7 +92,7 @@
        "mov	r3, r4\n"
   "1:\n\t"
 #ifdef __ARMEB__
-       "rors	r3, r3 #24\n\t"
+       "rors	r3, r3, #24\n\t"
 #endif
        "strb	r3, [ip], #1\n\t"
        "tst	r3, #0xff\n\t"

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]