Re: Errors with Re: [PATCH/RFA] Revamp wctomb/mbtowc conversion, add more charset support

[Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>]

> Date: Thu, 26 Mar 2009 10:34:26 +0100
> From: Corinna Vinschen <vinschen@redhat.com>

> On Mar 26 04:29, Hans-Peter Nilsson wrote:
> > I can't find any mentioning how you tested these patches.  Could
> > you please regtest gcc with all applicable languages on a
> > non-cygwin newlib (simulator) target of your choice?  I'm not
> > ruling out the gcc regressions being visible on cygwin too, I'm
> > just assuming you regtested gcc for cygwin and these changes.
> 
> No, I'm not building gcc, I'm building and testing Cygwin itself.

Testing for more than that target would have been prudent, as
your change affected more than cygwin.

> It would be much more helpful if you send a simple testcase to
> demonstrate the problem.

I didn't have one, and didn't spend time investigating to find
the failing function and compose one as I thought you'd promptly
run (to) the gcc testsuites yourself and have a look.

Anyway, my autotester (and the gcc test-suite results for
cris-elf) gives thumbs up for the updates.  Thanks for the
prompt action!

brgds, H-P
PS: I replied about the redhat.com SPF records mismatch privately.