This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: Errors with Re: [PATCH/RFA] Revamp wctomb/mbtowc conversion, add more charset support
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: newlib at sourceware dot org
- Cc: newlib at sourceware dot org
- Date: Sat, 28 Mar 2009 14:02:14 +0100
- Subject: Re: Errors with Re: [PATCH/RFA] Revamp wctomb/mbtowc conversion, add more charset support
> Date: Thu, 26 Mar 2009 16:38:09 +0100
> From: Corinna Vinschen <vinschen@redhat.com>
> On Mar 26 16:07, Hans-Peter Nilsson wrote:
> > > It would be much more helpful if you send a simple testcase to
> > > demonstrate the problem.
> >
> > I didn't have one, and didn't spend time investigating to find
> > the failing function and compose one as I thought you'd promptly
> > run (to) the gcc testsuites yourself and have a look.
>
> Huh? Newlib isn't all about gcc. I'm not developing gcc at all, so how
> on earth should I think of running a gcc testsuite in the first place?
> That's a bit far-fetched.
This wasn't in the "first place" - this was after my report.
You apparently found what was needed there, so what's far-fetched?
At the time, I bundled you with (other) Red Hat tool-chain
developers - perhaps wrongly; perhaps cygwin only it is - which
I didn't think would see using the gcc (libraries) test-suite
for coverage for a library change as far-fetched any time.
Anyway, your testing had a lack of coverage. Using the gcc
test-suite can fix part of that.
brgds, H-P