This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [RFA:] stdint.h: Add INTPTR_MIN, INTPTR_MAX, UINTPTR_MAX
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: howland at LGSInnovations dot com
- Cc: newlib at sourceware dot org, hans-peter dot nilsson at axis dot com
- Date: Thu, 9 Apr 2009 02:23:43 +0200
- Subject: Re: [RFA:] stdint.h: Add INTPTR_MIN, INTPTR_MAX, UINTPTR_MAX
> Date: Wed, 8 Apr 2009 20:03:10 -0400
> From: "Howland Craig D (Craig)" <howland@LGSInnovations.com>
> The first is related directly to the patch. The problem is that when
> __PTRDIFF_TYPE__ is defined, PTRDIFF_MAX and PTRDIFF_MIN are used but
> they are not defined.
Are you reading the same stdint.h as I do? CVS 1.13 has
PTRDIFF_MAX and MIN defined in the chunk that starts at line
410, regardless of __PTRDIFF_TYPE__ or __PTRDIFF_MAX__ for that
matter. Unless I'm missing something. And if I had, the
regtest would have caught it - or at least shown that it didn't
work. :)
> Secondly, not directly related to the patch, I noticed that the related
> part of stdint.h is not safe across all possible platforms.
I'm aiming for improvement, not for fixing up existing flaws (at
least not those that don't have practical impact).
> The part of stdint.h under scrutiny is (not showing the patch
> additions):
>
> /*
> * GCC doesn't provide an appropriate macro for [u]intptr_t
> * For now, use __PTRDIFF_TYPE__
> */
> Any other ideas? (Maybe when this patch goes in, a FIXME note could be
> added for until a proper fix can be done.)
I'm all for that, but the quoted comment serves this purpose
IMHO.
brgds, H-P