This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] add <sys/dir.h>

From: Eric Blake <eblake at redhat dot com>
To: newlib at sourceware dot org
Date: Wed, 11 Aug 2010 08:40:14 -0600
Subject: Re: [PATCH] add <sys/dir.h>
References: <1281500088.4080.95.camel@YAAKOV04> <4C62B21B.8000009@redhat.com> <20100811143857.GA462@calimero.vinschen.de>

On 08/11/2010 08:38 AM, Corinna Vinschen wrote:
>> <dirent.h> should be providing the C++ guards.  If it is, this instance
>> in <sys/dir.h> is redundant; if it isn't, then <dirent.h> needs fixing.
>>
>> /me goes to check...
>> Hmm - <dirent.h> _is_ providing C++ guards, but then it includes
>> <sys/dirent.h> inside guards.  Which means <sys/dirent.h> needs fixing too.
> 
> Why?  An application should never include sys/dirent.h directly, right?

Fair enough for <sys/dirent.h>; but we should still remove the redundant
guards from <sys/dir.h>.

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Follow-Ups:
- Re: [PATCH] add <sys/dir.h>
  - From: Corinna Vinschen

References:
- [PATCH] add <sys/dir.h>
  - From: Yaakov (Cygwin/X)
- Re: [PATCH] add <sys/dir.h>
  - From: Eric Blake
- Re: [PATCH] add <sys/dir.h>
  - From: Corinna Vinschen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]