Re: patch to add C99 complex

[Corinna Vinschen <vinschen at redhat dot com>]

Hi Marco,

On Oct  6 07:54, Marco Atzeri wrote:
> The attached patch add C99 Complex to newlib
> using all NETBSD source except "long double" ones.

Thanks for the patch.  It's nice to get the C99 complex functions into
newlib.  However, here's a question:

The cabs{f}, carg{f} functions are using the GCC extensions __real__ and
__imag__.  Other functions are calling the official creal{f} and
cimag{f} functions.  AFAICS cabs{f} and carg{f} should do the same.
Would you mind to fix this?

Oh, and, please, when you send a patch, send it uncompressed.  If it
doesn't fit into one mail, split it.  And please, send the ChangeLog
entry as is, always separate from the actual patch in your mail.  A
patch of a ChangeLog entry almost never applies cleanly, so the patch of
it has not much value.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat