This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch to add C99 complex - 1/3


On 10/07/2010 05:14 AM, Corinna Vinschen wrote:
Hi Marco,

On Oct 7 07:52, Marco Atzeri wrote:
--- Mer 6/10/10, Dave Korn ha scritto:

On 06/10/2010 17:58, Marco Atzeri
wrote:

-SUBLIBS = $(MATHDIR)/lib$(MATHDIR).$(aext)
common/libcommon.$(aext) $(LIBM_MACHINE_LIB)
+SUBLIBS = $(MATHDIR)/lib$(MATHDIR).$(aext)
common/libcommon.$(aext)complex/libcomplex.$(aext)
$(LIBM_MACHINE_LIB)


There's a missing space there between the libcommon and libcomplex entries.

     cheers,
       DaveK


Thanks, amended

Marco

That looks good and it builds fine. However, there's something missing which didn't occur to me at first sight: Documentation. It's not very tricky to add, just see the libm/math/math.tex file and the header of, for instance, the libm/math/s_atan.c file. Would you mind to add that?

I'm off for a few weeks starting tomorrow so I'm not sure how to handle
this.  Jeff, is it ok to apply the patch as is for now and Marco adds
the docs later?



No problem.


-- Jeff J.
Corinna



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]