This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: possible bug in newlib-1.18.0/newlib/libc/machine/i386/setjmp.S
- From: Corinna Vinschen <vinschen at redhat dot com>
- To: newlib at sourceware dot org
- Date: Tue, 16 Nov 2010 18:53:12 +0100
- Subject: Re: possible bug in newlib-1.18.0/newlib/libc/machine/i386/setjmp.S
- References: <1288874412.3471.11.camel@host>
- Reply-to: newlib at sourceware dot org
On Nov 4 15:40, Andrew Makhorin wrote:
> Hello,
>
> I think that I found a bug in
> newlib-1.18.0/newlib/libc/machine/i386/setjmp.S .
> Namely, if longjmp is called with zero val (second argument), it causes
> setjmp to return 0 rather than 1.
>
> Probably the bug can be fixed as follows:
>
> SYM (longjmp):
> pushl ebp
> movl esp,ebp
>
> movl 8(ebp),edi /* get jmp_buf */
> movl 12(ebp),eax /* store retval in j->eax */
> + test eax,eax
> + jnz skip
> + inc eax /* if eax = 0 then eax := 1 */
> +skip:
> movl eax,0(edi)
> . . .
Thanks for the hint. I applied a matching patch.
Corinna
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat