This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: building bug

From: Jeff Johnston <jjohnstn at redhat dot com>
To: Mike Frysinger <vapier at gentoo dot org>
Cc: newlib at sourceware dot org, Mike Stump <mikestump at comcast dot net>
Date: Mon, 08 Aug 2011 14:42:52 -0400
Subject: Re: building bug
References: <E719CB2B-494B-4E23-BC31-8CDC048FF36F@comcast.net> <201108072024.03805.vapier@gentoo.org>

On 08/07/2011 08:24 PM, Mike Frysinger wrote:

On Thursday, August 04, 2011 02:56:17 Mike Stump wrote:

-             (cd $$dir; $(MAKE) $(FLAGS_TO_PASS)); \
+             if (cd $$dir; $(MAKE) $(FLAGS_TO_PASS)); then \
+               true; \
+             else \
+               exit 1; \
+             fi; \


personally i'd use the oneliner:
              (cd $$dir; $(MAKE) $(FLAGS_TO_PASS)) || exit $$?; \
-mike

Actually, the exit 1 is consistent with what autotools are generating (see newlib/Makefile.in $(RECURSIVE_TARGETS). I am leaving it as-is to be consistent with the subdir_do target. The newlib generated targets also have checks for -k and instead of 'exit 1', set 'fail=yes'.

-- Jeff J.

References:
- building bug
  - From: Mike Stump
- Re: building bug
  - From: Mike Frysinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]