This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] misc. warning fixes


On Aug 20 06:38, Ralf Corsepius wrote:
> Hi,
> 
> I'd like to apply the patch below.
> 
> It addresses misc. warnings gcc issues when building newlib.
> 
> Ralf

> 2011-08-20  Ralf Cors??pius <...>
> 
> 	* libc/posix/regexec.c: Define "nope" only #ifndef NDEBUG.
> 	* libc/stdio/vfscanf.c: Define "state" only #ifdef _MB_CAPABLE.
> 	* libc/string/wcwidth.c: Include <wctypes.h> for "iswprint" and
> 	"iswcntrl".

The latter two are ok.  For the first one, I think we should just
remove `nope'.  It's not used anywhere in regexec.c, nor is NDEBUG.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]