This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Add Epiphany newlib & libgloss port


Joern Rennecke wrote:
> Quoting Jim Meyering <jim@meyering.net>:
>
>> I was curious, so did a casual review and spotted a few problems.
>
> Thanks.

I see no changes under /libgloss, so perhaps you
weren't addressing me.  For example, open is still buggy:

int __attribute__ ((section ("libgloss_epiphany")))
_open (char *file,
       int   flags,
       int   mode)
{
  int status = asm_open (file, flags, mode);
  if (!status) {
    errno = status;
    return -1;
  }
  return status;
}	/* _open () */


> Attached is an updated version of the port.  I didn't change
> configure.ac -> configure.in , as this is still not done for other
> ports, either.
>
> The ChangLog entry is also slightly changed to take account of a former
> third contributor.
...
> libgloss:
>          * configure.in: Add Epiphany support.
>          * configure: Regenerate.
>          * epiphany: New directory.
>          * libgloss/README: Add Epiphany entry.

This file has no newline at EOF.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]