This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: pthread.h: Add missing PTHREAD_RWLOCK_INITIALIZER


On 11/12/2012 06:19 PM, Joel Sherrill wrote:
Hi

Attached is a very simple 1 line patch which adds the
missing constant PTHREAD_RWLOCK_INITIALIZER and
makes it have the same value as the other similar
constants.

OK to commit?

No.


2012-11-12 Joel Sherrill <joel.sherrill@oarcorp.com>

* libc/include/pthread.h: Add PTHREAD_RWLOCK_INITIALIZER.


Is it your intention to initialize to -1?


If so, initialization to 0xffffffff would not return -1 on platforms with size > 32 bit.

Also, your construct would fail on platforms with sizeof(ptr) < 32bit.

Ralf





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]