This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: Patch for faster memcpy on MIPS
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Steve Ellcey " <sellcey at mips dot com>
- Cc: <rsandiford at googlemail dot com>, <newlib at sourceware dot org>, <apinski at cavium dot com>, <stevenb dot gcc at gmail dot com>
- Date: Fri, 04 Jan 2013 09:02:39 +0000
- Subject: Re: Patch for faster memcpy on MIPS
- References: <a63e6974-f440-4c3e-bae8-1536f0dafd4f@EXCHHUB01.MIPS.com>
"Steve Ellcey " <sellcey@mips.com> writes:
> diff --git a/newlib/libc/machine/mips/memcpy.S
> b/newlib/libc/machine/mips/memcpy.S
> index fe7cb15..8db8953 100644
> --- a/newlib/libc/machine/mips/memcpy.S
> +++ b/newlib/libc/machine/mips/memcpy.S
> @@ -203,7 +203,7 @@
> #define REG1 t1
> #define REG2 t2
> #define REG3 t3
> -#if _MIPS_SIM == _ABIO32
> +#if defined(_MIPS_SIM) && (_MIPS_SIM == _ABIO32)
> # define REG4 t4
> # define REG5 t5
> # define REG6 t6
I think you want:
#if defined(_MIPS_SIM) && (_MIPS_SIM == _ABIO32 || _MIPS_SIM == _ABIO64)
here. o64 has 4 argument registers, like o32. (mips64-elf uses o64 FWIW.)
Richard