This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] ARM: Use local labels in strcmp.S

strcmp.S defines lots of labels not starting with .L, like
strcmp_unaligned:

Comparing to preferred style of starting local labels with .L, these labels
has two issues:
1. Forcing assembler to use 32bit encoding for branches to these labels,
because of http://sourceware.org/bugzilla/show_bug.cgi?id=12532 . This might
be a GAS bug as it shouldn't treat them as global symbols if not declared
with .global.
2. Adding unnecessary symbols in symbol table of target object and binary

This patch fixes it. Size of strcmp is reduced from 584 to 540 for thumb2.
No performance change observed.

OK to trunk?

ChangeLog:
    * libc/machine/arm/strcmp.S: Use local labels.

Attachment: strcmp_label-0603.patch.txt
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]