Re: [PATCH 2/7] Use <stdint.h> in <machine/_default_types.h>

[Corinna Vinschen <vinschen at redhat dot com>]

On Oct  8 15:47, Sebastian Huber wrote:
> On 2013-10-08 14:45, Sebastian Huber wrote:
> >This change ensures that the default integer types are identical to the
> >corresponding C99 types.  On some targets the type of uint32_t and
> >__uint32_t were not identical which resulted in compiler warnings.
> >
> >newlib/ChangeLog
> >2013-10-08  Sebastian Huber <sebastian.huber@embedded-brains.de>
> >
> >	* libc/include/machine/_default_types.h (__int8_t): Define via
> >	<stdint.h> provided type.
> >	(__uint8_t): Likewise.
> >	(__int8_least_t): Likewise.
> >	(__uint8_least_t): Likewise.
> >	(__int16_t): Likewise.
> >	(__uint16_t): Likewise.
> >	(__int16_least_t): Likewise.
> >	(__uint16_least_t): Likewise.
> >	(__int32_t): Likewise.
> >	(__uint32_t): Likewise.
> >	(__int32_least_t): Likewise.
> >	(__uint32_least_t): Likewise.
> >	(__int64_t): Likewise.
> >	(__uint64_t): Likewise.
> 
> This patch is also not RTEMS specific and potentially controversial.

Defining __foo in terms of foo looks a bit weird, but the resulting
_default_type.h looks pretty neat.  I tried to find reasons that this
may break something but I can't come up with anything.  So, if nobody
knows a good reason not to do this, we should give it a try.  Please
check in.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgp0Bq7fwy3gG.pgp
Description: PGP signature