Re: [PATCH] Fix use after free in closedir

[Corinna Vinschen <vinschen at redhat dot com>]

On Nov 13 11:48, Eric Blake wrote:
> On 11/13/2013 11:01 AM, Corinna Vinschen wrote:
> 
> > 
> > That sounds good to me.  I'd just like to wait a couple of days if
> > somebody has some insight in terms of this fd == -1 checks we're
> > both not aware of.
> 
> POSIX allows an implementation where readdir does not use an fd; such an
> implementation still has to have an associated fd for purposes of
> dirfd() but need not otherwise care about use of that fd.  But as far as
> newlib is concerned, our readdir implementation requires the use of the
> fd, and I don't see us ever trying to take advantage of POSIX' notion of
> a fringe implementation where the fd is not actively required to get
> directory entries from the kernel.  So in my quick glance, I'm not
> seeing any obvious use for the fd == -1 checks in newlib.

Thanks for your feedback on this.  If nobody objects, I'll apply
the change later this week.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpknl_pcFuSy.pgp
Description: PGP signature