This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH v2] Harmonize stdint.h and _default_types.h
- From: Jeff Johnston <jjohnstn at redhat dot com>
- To: Steve Ellcey <sellcey at mips dot com>
- Cc: Sebastian Huber <sebastian dot huber at embedded-brains dot de>, newlib at sourceware dot org
- Date: Wed, 4 Dec 2013 14:34:11 -0500 (EST)
- Subject: Re: [PATCH v2] Harmonize stdint.h and _default_types.h
- Authentication-results: sourceware.org; auth=none
- References: <1386082328-18482-1-git-send-email-sebastian dot huber at embedded-brains dot de> <1386178165 dot 7831 dot 20 dot camel at ubuntu-sellcey> <529F67E0 dot 7000103 at embedded-brains dot de> <1386180695 dot 7831 dot 23 dot camel at ubuntu-sellcey>
Yes, please go ahead and check it in.
----- Original Message -----
From: "Steve Ellcey" <sellcey@mips.com>
To: "Sebastian Huber" <sebastian.huber@embedded-brains.de>
Cc: newlib@sourceware.org
Sent: Wednesday, December 4, 2013 1:11:35 PM
Subject: Re: [PATCH v2] Harmonize stdint.h and _default_types.h
On Wed, 2013-12-04 at 18:35 +0100, Sebastian Huber wrote:
> What about this fix:
>
> diff --git a/libgloss/mips/cfe_api.h b/libgloss/mips/cfe_api.h
> index b17f929..b79b0a0 100644
> --- a/libgloss/mips/cfe_api.h
> +++ b/libgloss/mips/cfe_api.h
> @@ -59,6 +59,7 @@
> * CFE_API_* can be defined here as desired.
> */
> /* Begin customization. */
> +#include <stdint.h>
> #include <string.h>
> #define cfe_strlen(s) strlen(s)
>
> This header file uses C99 types, so it should include <stdint.h>.
Yes, this fixes the build problem. Do you want to submit this patch
for approval and checkin or should I do that? Or maybe it is an obvious
fix that can just be checked in?
Steve Ellcey
sellcey@mips.com