Re: Add sigaltstack() prototype - Round 2

[Corinna Vinschen <vinschen at redhat dot com>]

On Aug 15 09:20, Joel Sherrill wrote:
> On 8/15/2014 8:46 AM, Corinna Vinschen wrote:
> > On Aug 15 08:26, Joel Sherrill wrote:
> >> 2014-08-15 Joel Sherrill <...>
> >>
> >>     * libc/include/sys/signal.h: Add sigaltstack() support.
> > Shouldn't this patch define the available flags, too?
> You are correct. It should. Obviously the code we were compiling didn't
> use them. :)
> 
> Attached is v3. Values follow those in glibc. Same ChangeLog.

Uhm, I'm sorry, but...

> Index: newlib/libc/include/sys/signal.h
> ===================================================================
> RCS file: /cvs/src/src/newlib/libc/include/sys/signal.h,v
> retrieving revision 1.22
> diff -u -r1.22 signal.h
> --- newlib/libc/include/sys/signal.h	26 Oct 2012 09:23:46 -0000	1.22
> +++ newlib/libc/include/sys/signal.h	15 Aug 2014 14:20:10 -0000
> @@ -104,6 +104,23 @@
>  #define sa_sigaction  _signal_handlers._sigaction
>  #endif
>  
> +#if __BSD_VISIBLE || __XSI_VISIBLE || __POSIX_VISIBLE >= 200112
> +/*
> + * Possible values for ss_flags in stack_t below.
> + */
> +#define SS_ONSTACK 0x1
> +#define SS_ONSTACK 0x2

...that's SS_DISABLE 0x2, right?

POSIX also defines SIGSTKSZ and MINSIGSTKSZ.  I'm wondering if we
shouldn't add default values here if the variables aren't already
defined.  Or would that rather be something for the target specific
config?


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpXdkFqxtgXh.pgp
Description: PGP signature