This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Declare sethostname() if __BSD_VISIBLE is defined

From: Corinna Vinschen <vinschen at redhat dot com>
To: newlib at sourceware dot org
Date: Fri, 24 Oct 2014 11:39:51 +0200
Subject: Re: [PATCH] Declare sethostname() if __BSD_VISIBLE is defined
Authentication-results: sourceware.org; auth=none
References: <1414137434-16394-1-git-send-email-sebastian dot huber at embedded-brains dot de>
Reply-to: newlib at sourceware dot org

Hi Sebastian,

On Oct 24 09:57, Sebastian Huber wrote:
> Prototype is according to glibc and not FreeBSD which uses int for the
> second parameter.  I am not sure how to do the alternative feature test
> described in the Linux manpage.

Testing for defined(__BSD_VISIBLE) seems wrong to me.  Per sys/cdefs.h
__BSD_VISIBLE is often define as 0.  Taking the Linux man page into
account, shouldn't that be something like

  #if __BSD_VISIBLE || (defined (_XOPEN_SOURCE) && __XSI_VISIBLE < 500)

?

Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpVr2VgYtVqC.pgp
Description: PGP signature

Follow-Ups:
- Re: [PATCH] Declare sethostname() if __BSD_VISIBLE is defined
  - From: Sebastian Huber

References:
- [PATCH] Declare sethostname() if __BSD_VISIBLE is defined
  - From: Sebastian Huber

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]