This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, Newlib]Remove unnecessary if comparison

From: Corinna Vinschen <vinschen at redhat dot com>
To: newlib at sourceware dot org
Date: Wed, 29 Oct 2014 12:07:53 +0100
Subject: Re: [Patch, Newlib]Remove unnecessary if comparison
Authentication-results: sourceware.org; auth=none
References: <000c01cff353$4b44a9e0$e1cdfda0$ at arm dot com>
Reply-to: newlib at sourceware dot org

On Oct 29 16:35, Terry Guo wrote:
> Hi there,
> 
> As shown in attached patch, the (p!=NULL) means we found target character
> within width 'prec'. So the 'size' is always smaller than the width 'prec',
> thus the inner if statement is unnecessary. Is it ok?
> 
> BR,
> Terry
> 
> newlib/ChangeLog
> 2014-10-29  Terry Guo  <...>
> 
>      * libc/stdio/vfprintf.c (_VFPRINTF_R): Remove unnecessary comparison.

Patch applied, except the NUL -> NULL part in the comment.  NUL refers
to the ASCII NUL character, NULL means a null pointer value.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpEPvBE936vQ.pgp
Description: PGP signature

References:
- [Patch, Newlib]Remove unnecessary if comparison
  - From: Terry Guo

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]