This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [libcxx+newlib] nexttoward{f,l,} shims for _LDBL_EQ_DBL systems
- From: Jeff Johnston <jjohnstn at redhat dot com>
- To: Jonathan Roelofs <jonathan at codesourcery dot com>
- Cc: Newlib Mailing List <newlib at sourceware dot org>
- Date: Tue, 9 Dec 2014 18:36:38 -0500 (EST)
- Subject: Re: [libcxx+newlib] nexttoward{f,l,} shims for _LDBL_EQ_DBL systems
- Authentication-results: sourceware.org; auth=none
- References: <5421D931 dot 905 at codesourcery dot com> <547E0B28 dot 1030407 at codesourcery dot com> <547E4F32 dot 6000201 at codesourcery dot com> <547E523B dot 6060703 at codesourcery dot com> <547F27F4 dot 2000007 at codesourcery dot com> <5487087D dot 60109 at codesourcery dot com> <360451599 dot 20515843 dot 1418163322593 dot JavaMail dot zimbra at redhat dot com> <548779F0 dot 5090308 at codesourcery dot com>
----- Original Message -----
> From: "Jonathan Roelofs" <jonathan@codesourcery.com>
> To: "Jeff Johnston" <jjohnstn@redhat.com>
> Cc: "JF Bastien" <jfb@chromium.org>, "Craig Howland" <howland@lgsinnovations.com>, newlib@sourceware.org
> Sent: Tuesday, December 9, 2014 5:38:40 PM
> Subject: Re: [libcxx+newlib] nexttoward{f,l,} shims for _LDBL_EQ_DBL systems
>
>
>
> On 12/9/14 3:15 PM, Jeff Johnston wrote:
> > Just a couple comments.
> >
> > 1. The FORCE_EVAL macro looks for
> > double or long double, even though it is only used for floats in
> > nexttowardf
> > By any chance was this macro in a header that you brought into
> > the code and if so, would it not be better to put the general-purpose
> > macro in local.h? Otherwise, I would just suggest removing the double/long
> > double
> > parts that are extraneous in this instance and clutter the code.
> FORCE_EVAL did come from a header, and yeah, local.h probably is a better
> place
> for it.
> >
> > If you took it from a header, please confirm the license was the same as
> > nexttowardf() which is fine btw for inclusion into newlib.
> That header has this at the top of it:
>
> * ====================================================
> * Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved.
> *
> * Developed at SunPro, a Sun Microsystems, Inc. business.
> * Permission to use, copy, modify, and distribute this
> * software is freely granted, provided that this notice
> * is preserved.
> * ====================================================
>
In that case, just do the volatile assignment manually instead of adding a
second license.
> >
> > 2. You have put the nexttowardf function prototype in the math.h section
> > where
> > _LDBL_EQ_DOUBLE is true but the code itself doesn't use the flag as
> > it doesn't rely on long double internals.
> Oh, right. Good point. I'll take it out of _LDBL_EQ_DOUBLE.
>
> Jon
> >
> > -- Jeff J.
> >
>
> --
> Jon Roelofs
> jonathan@codesourcery.com
> CodeSourcery / Mentor Embedded
>
- References:
- [libcxx+newlib] nexttoward{f,l,} shims for _LDBL_EQ_DBL systems
- Re: [libcxx+newlib] nexttoward{f,l,} shims for _LDBL_EQ_DBL systems
- Re: [libcxx+newlib] nexttoward{f,l,} shims for _LDBL_EQ_DBL systems
- Re: [libcxx+newlib] nexttoward{f,l,} shims for _LDBL_EQ_DBL systems
- Re: [libcxx+newlib] nexttoward{f,l,} shims for _LDBL_EQ_DBL systems
- Re: [libcxx+newlib] nexttoward{f,l,} shims for _LDBL_EQ_DBL systems
- Re: [libcxx+newlib] nexttoward{f,l,} shims for _LDBL_EQ_DBL systems