This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] __fsetlocking


On Dec 15 10:30, Yaakov Selkowitz wrote:
> On 2014-12-15 09:11, Corinna Vinschen wrote:
> >On Dec 11 12:08, Yaakov Selkowitz wrote:
> >>Another of the stdio_ext functions from Solaris and glibc:
> >>
> >>https://docs.oracle.com/cd/E19683-01/816-0213/6m6ne37vm/index.html
> >>http://man7.org/linux/man-pages/man3/stdio_ext.3.html
> >>
> >>Patch attached.
> >
> >Thanks.  This patch introduces a problem for single thread targets.
> >While _newlib_flockfile_start and friends where no-ops before (given
> >that _flockfile/_funlockfile are no-ops), they now introduce a redundant
> >check for a bit in fp->_flags2.  This check *may* be removed by compiler
> >optimization, but we shouldn't rely on that.  What this patch needs is a
> >new no-op-like definition of _newlib_flockfile_start and friends for
> >single thread targets.
> 
> Revised patch attached.

The __SINGLE_THREAD__ version works afaics, so, looks good.  Please
apply.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpiF8rPrhol4.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]