Re: problem in pthread.h

[Romano Paolo Tenca <rotenca at telvia dot it>]

Bossom, John wrote:
> The pthread_cleanup_push defines a scoped block that is completed by the
> pop macro.
> This scoping is necessary in order that the internal local variable,
> _cleanup, still exists at when the pop is actually called. The pop
> expects the values in the _cleanup to still be available.
>
>   
Yes, but check the original code: the block is closed in the wrong position.
> In pthread.h  2.7.0 line 762 i find:
>
> #define pthread_cleanup_push( _rout, _arg ) \
>         { \
>             ptw32_cleanup_t     _cleanup; \
>             \
>             ptw32_push_cleanup( &_cleanup, (ptw32_cleanup_callback_t)
> (_rout), (_arg) ); \
>
> #define pthread_cleanup_pop( _execute ) \
>             (void) ptw32_pop_cleanup( _execute ); \
>         }
>
> It seems to me that it must be:
>
> #define pthread_cleanup_push( _rout, _arg ) \
>         { \
>             ptw32_cleanup_t     _cleanup; \
>             ptw32_push_cleanup( &_cleanup, (ptw32_cleanup_callback_t)
> (_rout), (_arg) ); \
>         }
>
> #define pthread_cleanup_pop( _execute ) \
>        (void) ptw32_pop_cleanup( _execute );
>
>
>   
--

Romano Paolo Tenca