This is the mail archive of the
rhug-rhats@sources.redhat.com
mailing list for the RHUG project.
bug fix -- but no automake
- From: Tom Tromey <tromey at redhat dot com>
- To: rhug-rhats at sources dot redhat dot com
- Date: 10 Jul 2003 11:21:35 -0600
- Subject: bug fix -- but no automake
- Reply-to: tromey at redhat dot com
I don't have automake 1.5 installed anywhere. (This is a bogus
version to be using, anyway. 1.6 or 1.7 would be much better.)
This patch fixes a build problem I've been having.
CFLAGS is a user variable, setting it in Makefile.am is incorrect.
And in this case it breaks the build if you try to build
with "make CFLAGS=-g".
Could someone here with automake 1.5 apply this patch, rebuild
Makefile.in, and commit? I'd appreciate it if this could happen
soon... I'd like my nightly builds to start working again so I can
use jasmin.
I searched in all the Makefile.am in the tree and didn't see this
problem anywhere else, for either CFLAGS or CXXFLAGS.
Tom
Index: ChangeLog
from Tom Tromey <tromey@redhat.com>
* Makefile.am (AM_CFLAGS): Renamed from CFLAGS. Removed -O2;
this is supplied by configure.
Index: Makefile.am
===================================================================
RCS file: /cvs/rhug/rhug/gnu.readline/Makefile.am,v
retrieving revision 1.10
diff -u -r1.10 Makefile.am
--- Makefile.am 11 Jul 2002 13:49:29 -0000 1.10
+++ Makefile.am 10 Jul 2003 17:25:47 -0000
@@ -89,7 +89,7 @@
# JavaReadLine and JavaEditLine should be set according to what
# autoconf detects. FIXME
-CFLAGS = -O2 -DJNIEXPORT= -DJNICALL= -DJAVAREADLINE
+AM_CFLAGS = -DJNIEXPORT= -DJNICALL= -DJAVAREADLINE
lib_org_gnu_readline_la_SOURCES = \
./upstream/src/org/gnu/readline/Readline.java \