This is the mail archive of the systemtap-cvs@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[SCM] systemtap: system-wide probe/trace tool branch, master, updated. release-1.4-301-g0746c98


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "systemtap: system-wide probe/trace tool".

The branch, master has been updated
       via  0746c987640896c855bf2b63a166c8051c8f7654 (commit)
      from  9c334c568d6c92f27dc4a0ab322a50e8237f6d9c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0746c987640896c855bf2b63a166c8051c8f7654
Author: Josh Stone <jistone@redhat.com>
Date:   Fri May 6 16:31:08 2011 -0700

    uprobes: impedance match insn tables with test_bit()
    
    The kernel's test_bit expects its bitmap to be const volatile, but we
    had ours as simply const.  On Fedora 15 with gcc 4.6, compiling uprobes
    gave a few warnings like this:
    
        arch/x86/include/asm/bitops.h:319:2: warning: use of memory input
        without lvalue in asm operand 1 is deprecated [enabled by default]
    
    That line is the asm statement in variable_test_bit().
    
    The symptom noticed was that handle_riprel_insn was reading need_modrm:0
    for opcode 0x89, when our table says it should be 1.  Who knows what
    other havok ensued...
    
    When our instruction tables are set const volatile to match test_bit(),
    the warning goes away, and need_modrm is now computed correctly.

-----------------------------------------------------------------------

Summary of changes:
 runtime/uprobes/uprobes_i386.c   |    4 ++--
 runtime/uprobes/uprobes_x86.c    |   10 +++++-----
 runtime/uprobes/uprobes_x86_64.c |   10 +++++-----
 runtime/uprobes2/uprobes_x86.c   |   10 +++++-----
 4 files changed, 17 insertions(+), 17 deletions(-)


hooks/post-receive
--
systemtap: system-wide probe/trace tool


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]