This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: Runtime probes to load module parameters
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: Hien Nguyen <hien at us dot ibm dot com>
- Cc: systemtap at sources dot redhat dot com
- Date: 02 Aug 2005 20:49:09 -0400
- Subject: Re: Runtime probes to load module parameters
- References: <42F00537.4030106@us.ibm.com>
Hien Nguyen <hien@us.ibm.com> writes:
> - execl("/sbin/insmod", "insmod", modname, buf, NULL);
> + char cmd[2048];
> + sprintf(cmd, "/sbin/insmod %s %s", modname, buf);
> + execl("/bin/sh", "sh", "-c", cmd, NULL);
> [...]
I don't think systemtap would have any use for this option.
Regardless, it would be nice to stay away from something as insecure
as system() (or its equivalent being used here) for those extra args.
- FChE