This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] kprobe-booster: boosting multi-probe
- From: Prasanna S Panchamukhi <prasanna at in dot ibm dot com>
- To: Masami Hiramatsu <hiramatu at sdl dot hitachi dot co dot jp>
- Cc: systemtap at sources dot redhat dot com, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, "Keshavamurthy, Anil S" <anil dot s dot keshavamurthy at intel dot com>, Jim Keniston <jkenisto at us dot ibm dot com>, Satoshi Oshima <soshima at redhat dot com>, Yumiko Sugita <sugita at sdl dot hitachi dot co dot jp>, Hideo Aoki <haoki at redhat dot com>, Maneesh Soni <maneesh at in dot ibm dot com>
- Date: Fri, 17 Feb 2006 15:22:56 +0530
- Subject: Re: [PATCH] kprobe-booster: boosting multi-probe
- References: <43F59215.5040300@sdl.hitachi.co.jp>
- Reply-to: prasanna at in dot ibm dot com
Masami,
Please see few coding style issues inline below marked with "^^^".
Thanks
Prasanna
>
> +static inline void boost_aggr_kprobe(struct kprobe *ap)
> +{
> + struct kprobe *kp;
> + if (ap->post_handler || ap->break_handler) {
^^^^^^^^^^^
Could you please, leave a line after local variables as shown below
struct kprobe *kp;
if (ap->post_handler || ap->break_handler) {
> kfree(old_p);
> }
> arch_remove_kprobe(p);
> + } else {
> + boost_aggr_kprobe(old_p);
> }
^^^^^^^^^
This does not look good, could you please remove the "{" for else
condition, since it is just a single line, as shown below
else
boost_aggr_kprobe(old_p);
--
Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Email: prasanna@in.ibm.com
Ph: 91-80-51776329