This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[Bug kprobes/2476] New: Switch Kprobes inline functions to __kprobes?
- From: "jkenisto at us dot ibm dot com" <sourceware-bugzilla at sourceware dot org>
- To: systemtap at sources dot redhat dot com
- Date: 23 Mar 2006 00:45:00 -0000
- Subject: [Bug kprobes/2476] New: Switch Kprobes inline functions to __kprobes?
- Reply-to: sourceware-bugzilla at sourceware dot org
In LKML on 3/20/2006, Andrew Morton said:
> +static inline int uprobe_fault_handler(struct pt_regs *regs, int trapnr)
If, for some reason, the compiler decides to not inline this function then
you have a hunk of code which isn't marked __kprobes, but it should be.
I'd suggest that you remove all inlining from this code and add the
appropriate section markers.
Or I guess you could use __always_inline, but I'm not sure that it's really
worth the fuss and obscurity of doing that.
All kprobes-related code should be audited for this problem.
--
Summary: Switch Kprobes inline functions to __kprobes?
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: kprobes
AssignedTo: systemtap at sources dot redhat dot com
ReportedBy: jkenisto at us dot ibm dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=2476
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.