This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 3/16] LTTng 0.6.36 for 2.6.18 : Linux Kernel Markers
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: Mathieu Desnoyers <mathieu dot desnoyers at polymtl dot ca>
- Cc: linux-kernel at vger dot kernel dot org, Christoph Hellwig <hch at infradead dot org>, Andrew Morton <akpm at osdl dot org>, Ingo Molnar <mingo at redhat dot com>, Greg Kroah-Hartman <gregkh at suse dot de>, Thomas Gleixner <tglx at linutronix dot de>, Tom Zanussi <zanussi at us dot ibm dot com>, Karim Yaghmour <karim at opersys dot com>, Paul Mundt <lethal at linux-sh dot org>, Jes Sorensen <jes at sgi dot com>, Richard J Moore <richardj_moore at uk dot ibm dot com>, "Martin J. Bligh" <mbligh at mbligh dot org>, Michel Dagenais <michel dot dagenais at polymtl dot ca>, Douglas Niehaus <niehaus at eecs dot ku dot edu>, ltt-dev at shafik dot org, systemtap at sources dot redhat dot com
- Date: 27 Nov 2006 21:23:17 -0500
- Subject: Re: [PATCH 3/16] LTTng 0.6.36 for 2.6.18 : Linux Kernel Markers
- References: <20061124215401.GD25048@Krystal>
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> writes:
> This patch adds the Linux Kernel Markers [...]
> Signed-off-by : Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
If it helps,
Acked-by: Frank Ch. Eigler <fche@redhat.com>
One question:
> [...]
> + /* Markers in modules. */
> + list_for_each_entry(mod, &modules, list) {
> + if (mod->license_gplok)
> + found += marker_set_probe_range(name, format, probe,
> + mod->markers, mod->markers+mod->num_markers);
> + }
> [...]
> +EXPORT_SYMBOL(marker_set_probe);
Are you sure the license_gplok check is necessary here? We should
consider encouraging non-gpl module writers to instrument their code,
to give users a slightly better chance of debugging problems.
- FChE