This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] Relay CPU Hotplug support
- From: Mathieu Desnoyers <mathieu dot desnoyers at polymtl dot ca>
- To: Tom Zanussi <zanussi at us dot ibm dot com>
- Cc: linux-kernel at vger dot kernel dot org, David Wilder <dwilder at us dot ibm dot com>, Andrew Morton <akpm at osdl dot org>, Ingo Molnar <mingo at redhat dot com>, Greg Kroah-Hartman <gregkh at suse dot de>, Christoph Hellwig <hch at infradead dot org>, ltt-dev at shafik dot org, systemtap at sources dot redhat dot com, Douglas Niehaus <niehaus at eecs dot ku dot edu>, "Martin J. Bligh" <mbligh at mbligh dot org>, Thomas Gleixner <tglx at linutronix dot de>
- Date: Wed, 20 Dec 2006 22:22:15 -0500
- Subject: Re: [PATCH] Relay CPU Hotplug support
- References: <20061221003101.GA28643@Krystal> <17801.57293.790405.25052@gargle.gargle.HOWL>
* Tom Zanussi (zanussi@us.ibm.com) wrote:
> Mathieu Desnoyers writes:
> > Hi,
> >
> > Here is a patch, result of the combined work of Tom Zanussi and myself, to add
> > CPU hotplug support to Relay.
> >
> > This patch applies on 2.6.20-rc1-git7.
> >
> > Signed-off-by : Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
> >
>
> Hi Mathieu,
>
> It looks like you forgot to include the Documentation update with
> this. Other than that, it looks fine to me.
>
> Acked-by: Tom Zanussi <zanussi@us.ibm.com>
>
>
Here is the missing part of the patch for documentation.
Thanks for pointing it out.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
--- a/Documentation/filesystems/relay.txt
+++ b/Documentation/filesystems/relay.txt
@@ -157,7 +157,7 @@ TBD(curr. line MT:/API/)
channel management functions:
relay_open(base_filename, parent, subbuf_size, n_subbufs,
- callbacks)
+ callbacks, private_data)
relay_close(chan)
relay_flush(chan)
relay_reset(chan)
@@ -251,7 +251,7 @@ static struct rchan_callbacks relay_call
And an example relay_open() invocation using them:
- chan = relay_open("cpu", NULL, SUBBUF_SIZE, N_SUBBUFS, &relay_callbacks);
+ chan = relay_open("cpu", NULL, SUBBUF_SIZE, N_SUBBUFS, &relay_callbacks, NULL);
If the create_buf_file() callback fails, or isn't defined, channel
creation and thus relay_open() will fail.
@@ -289,6 +289,11 @@ they use the proper locking for such a b
writes in a spinlock, or by copying a write function from relay.h and
creating a local version that internally does the proper locking.
+The private_data passed into relay_open() allows clients to associate
+user-defined data with a channel, and is immediately available
+(including in create_buf_file()) via chan->private_data or
+buf->chan->private_data.
+
Channel 'modes'
---------------
--
OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68