This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [Ltt-dev] [PATCH 10/10] local_t : x86_64 : local_add_return
- From: Mathieu Desnoyers <compudj at krystal dot dyndns dot org>
- To: linux-kernel at vger dot kernel dot org, Andrew Morton <akpm at osdl dot org>, Ingo Molnar <mingo at redhat dot com>, Greg Kroah-Hartman <gregkh at suse dot de>, Christoph Hellwig <hch at infradead dot org>
- Cc: Douglas Niehaus <niehaus at eecs dot ku dot edu>, "Martin J. Bligh" <mbligh at mbligh dot org>, ltt-dev at shafik dot org, Thomas Gleixner <tglx at linutronix dot de>, systemtap at sources dot redhat dot com
- Date: Thu, 21 Dec 2006 14:46:52 -0500
- Subject: Re: [Ltt-dev] [PATCH 10/10] local_t : x86_64 : local_add_return
- References: <20061221001545.GP28643@Krystal> <20061221002944.GZ28643@Krystal>
local_add_return should also deal with the removed volatile from local_t.
Inspired from atomic_t modifications : it must use the local_t both as input and
output.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
--- a/include/asm-x86_64/local.h
+++ b/include/asm-x86_64/local.h
@@ -136,8 +136,8 @@ static __inline__ long local_add_return(
long __i = i;
__asm__ __volatile__(
"xaddq %0, %1;"
- :"=r"(i)
- :"m"(l->a.counter), "0"(i));
+ :"+r" (i), "+m" (l->a.counter)
+ : : "memory");
return i + __i;
}
--
OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68