This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug translator/4066] hist_linear() with large H value crashes system


------- Additional Comments From joshua dot i dot stone at intel dot com  2007-02-16 22:41 -------
(In reply to comment #0)
> I suspect there's a problem in _stp_stat_init().

The problem is we're not checking the return value.  The initialization code for
"reads" goes:

  global_reads = _stp_stat_init (HIST_LINEAR, 0, 300000000000, 50);
  if (rc) {
    _stp_error ("global variable reads allocation failed");
    goto out;
  }
  rwlock_init (& global_reads_lock);

_stp_stat_init returns NULL if a problem occurs, but the caller is only checking
'rc', which is untouched.



-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=4066

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]