Re: Generic test suite failures found with ARM testing

[Martin Hunt <hunt at redhat dot com>]

On Thu, 2007-06-14 at 09:11 -0500, David Smith wrote:
> Quentin Barnes wrote:
> > I've run across two test failures on ARM that are not ARM-specific.  They
> > are with systemtap.samples/profile.exp and systemtap.samples/syscalls2.exp.
> > These tests fail for me because of the 128 character limit on strings.
> > 
> > For example, with profile.exp the output being looked for is truncated:
> >     staprun(4619) 
> > kernel.function("sys_poll@/proj/cost/work/qbarnes/kprobes/work/usr/src/linux-2.6.21.4/fs/select.c:742").call 
> > coun^M
> 
> The reason why we haven't noticed this problem is that you are evidently 
> compiling your kernel differently than we are.  

I've seen this before. It happens if you use "make O=output/dir" to
build your kernel.


> I believe the following patch will fix the problem by removing the 
> strcats.  If this works for you I'll check it in.
> 
> diff -u -p -r1.2 profile.stp
> --- testsuite/systemtap.samples/profile.stp     2 Apr 2007 20:30:30 
> -0000      1.2
> +++ testsuite/systemtap.samples/profile.stp     14 Jun 2007 14:10:01 -0000
> @@ -30,9 +30,9 @@ probe timer.ms(5000) {
>   }
>   probe end {
>     foreach ([pid,syscall] in syscall_count-) {
> -    log (command[pid] . "(" . sprint(pid) . ") " . syscall .
> -         " count=" . sprint(syscall_count[pid,syscall]) .
> -         " ttime=" . sprint(syscall_times[pid,syscall]))
> +    printf("%s(%d) %s count=%d ttime=%d\n", command[pid], pid, syscall,
> +          syscall_count[pid,syscall], syscall_times[pid,syscall])
> +
>       if (count++ > 30) next
>     }
>   }
> 

I think removing all uses of the dot concatenation operator would be a
good idea. Maybe keep a specific testcase around for backwards
compatibility.

Martin