This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch]Fix the args' output of syscall execve


Martin Hunt <hunt@redhat.com> writes:

> [...]
> Looks OK for trivial cases, but compare
> strace way:
> [pid 11943] execve("/usr/bin/g++", ["g++"..., "-DHAVE_CONFIG_H"...,
> "-I."..., "-I."..., "-I."..., [...]

Right, but strace is being silly putting dots after all those short
complete strings, which we wouldn't have to copy, ...

> systemtap script:
> [pid 12965] /usr/bin/g++ -DHAVE_CONFIG_H -I. -I. -I.
> -DBINDIR="/usr/local/bin" -DPKGDATADIR="/usr/local/share/systemtap"
> [...]

... and systemtap is hiding possible segmentation/quoting/argv0
problems.  How about using the strace format by default for things,
except when it makes no sense?  For this case, I'd be happy with

# [pid 11943] execve("/usr/bin/g++", ["g++", "-DHAVE_CONFIG_H",
# "-I.", "-I.", "-I.", [...]


- FChE


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]