This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] enhance quoting for command string


Hi -

> [...test case...]
> Checked in. See systemtap.base/cmd_parse.exp.

Thanks, it's a good start.

> [...]
> I guess we are not talking about the same thing?  I thought when you
> objected to using system() instead of exec() you meant running the
> commands directly instead of in a shell, like system() does. 

Yes, whatever it takes to make us invulnerable to transcription errors
occurring from gluing together then parsing apart argument lists in
strings.

> [...] Internally this [exec sh -c STRING] is exactly what
> [tapset] system() does.  However we could never use [unix] system()
> because [unix] system() waits for we process to complete before
> returning.

(Sure, but we already fork(2) before exec(2).  One could conceivably
use system(3) there.)

- FChE


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]