Re: Proposal for small addition to testsuite output

[Wenji Huang <wenji dot huang at oracle dot com>]

Hi,

 According to Kris' proposal, I made a small change to systemtap.exp.

 To add system info to the top of loge, I had a trick to replace 
logname with logname+system_info. If there is better way, correct me.

 Please kindly review the patch and sample of log for good committing.

Thanks,
Wenji
 

Kris Van Hees wrote:

> In followup to various chats at OLS about adding reporting on snapshot test
> execution for systemtap to 'labrat', I've been looking at the minimum amount
> of changes that would be needed to get enough metadata in the report to
> satisfy the requirements of labrat's reporting infrastructure.
>
> Although the initial thought was to provide a wrapper script for the testsuite
> execution that would generate an output file that is in labrat-format already,
> I instead decided that it is probably more useful to have the extra metadata
> recorded in the currently generated systemtap.log file, and perform the
> wrapper operation on the reporting end.  The main reason for this is that we
> hope to be able to support systemtap in full using the labrat client scripts.
> That would make it unnecessary to do any encapsulation.
>
> The three piece of information that I'd like to have added to the output are:
>
> - The name (date) of the snapshot being tested
> - The "uname -a" output for the host the testsuite is being executed on
> - The content of the distribution release/version file:
> 	/etc/fedora-release	for Fedora
> 	/etc/redhat-release	for Red Hat
> 	/etc/suse-release	for SuSE
> 	/etc/debian_version	for Debian/Ubuntu
>
> The preference would be to have them listed near the very top of the output
> log, if at all possible.
>
> I'll ask Wenji to prepare a patch for this, and I'll send private email to the
> people who are currently running the snapshot testsuite with information on
> where results can be uploaded.
>
> Aside from this, I am currently finalizing the code on the reporting server to
> provide historical data on a per-test level, to assist with trend analysis of
> test executions.  During our talks at OLS, that was raised as an important
> feature-to-have for labrat.
>
> 	Cheers,
> 	Kris
>
>  
--- src/testsuite/lib/systemtap.exp	2007-08-31 04:29:57.000000000 -0400
+++ src.new/testsuite/lib/systemtap.exp	2007-08-31 04:24:48.000000000 -0400
@@ -1,4 +1,17 @@
 load_lib site.exp
+proc get_system_info {} {
+    global Host Snapshot Distro
+    set Host [exec /bin/uname -a]
+    regexp {version [^)]*} [exec stap -V 2>@ stdout] Snapshot #copy from the following proc
+    set Distro "Linux"
+    if [file exists /etc/fedora-release] {set Distro [exec /bin/cat /etc/fedora-release]}
+    if [file exists /etc/redhat-release] {set Distro [exec /bin/cat /etc/redhat-release]}
+    if [file exists /etc/suse-release] {set Distro [exec /bin/cat /etc/suse-release]}
+    if [file exists /etc/debian_version] {set Distro [exec /bin/cat /etc/debian_version]}
+}
+
+get_system_info
+set logname "$logname\nHost: $Host\nSnapshot: $Snapshot\nDistro: $Distro\n"
 
 proc installtest_p {} {
     global TOOL_OPTIONS

Test Run By wjhuang
Host: Linux dhcp-beijing-cdc-10-182-121-14.cn.oracle.com 2.6.22.1 #10 Fri Aug 10 01:10:04 EDT 2007 i686 i686 i386 GNU/Linux
Snapshot: version 0.6/0.127 built 2007-08-27
Distro: Enterprise Linux Enterprise Linux Server release 5 (Carthage)
 on Fri Aug 31 04:33:03 2007
Native configuration is i686-redhat-linux-gnu

		=== systemtap tests ===

Schedule of variations:
    unix

Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using /home/wjhuang/systemtap/src/testsuite/config/unix.exp as tool-and-target-specific interface file.
..............................................Cut here...............................