This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -mm] relayfs: support larger relay buffer take 3
- From: Tom Zanussi <tzanussi at gmail dot com>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Pekka J Enberg <penberg at cs dot helsinki dot fi>, David Wilder <dwilder at us dot ibm dot com>, Andrew Morton <akpm at linux-foundation dot org>, systemtap-ml <systemtap at sources dot redhat dot com>, LKML <linux-kernel at vger dot kernel dot org>
- Date: Wed, 16 Apr 2008 23:05:28 -0500
- Subject: Re: [PATCH -mm] relayfs: support larger relay buffer take 3
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; bh=BokLgg1G/1YPZ0GIF07tCbImQohcijxr11DgjLgh5OI=; b=vJS4xLm53BjC52Bu8KF/EPHe+b09yjMigPSKJmZIZXmn0fQu+rLEJ832zl1OBzR3DLiu6s3feDORKtJ4T9ltBEo8sf93smAmthSb9bwR2OORwkY7tRrHJBtmbVu5Pkygi38Juz9OcMKlAq4u9xfaraW0sscZyQBcTwiqTxQpkDs=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; b=Z4fVgBY3jeigLshtjEyUnclSu9cOMpGJKuNOmQMpkYF4TJK74bGD0AwCpPwfrqMltads7OSA4QArTJjkffhK3e9UC3fJmF6xNTVRwPuipWz3qyjWHH7ckZA99b5vNOJCz45hdnyclGwhr4vqjDuhsiANwweqS7tVcRnm+NNbcik=
- References: <4804C95F.2080204@redhat.com> <1208319769.7893.16.camel@charm-linux> <48063F80.9060404@redhat.com> <Pine.LNX.4.64.0804162110070.19171@sbz-30.cs.Helsinki.FI> <480646B2.9000905@redhat.com> <480658DC.6030507@redhat.com>
On Wed, 2008-04-16 at 15:51 -0400, Masami Hiramatsu wrote:
> Use vmalloc() and memset() instead of kcalloc() to allocate a page* array
> when the array size is bigger than one page. This enables relayfs to support
> bigger relay buffers than 64MB on 4k-page system, 512MB on 16k-page system.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
> ---
> Changes from take2 to take3:
> - Use struct page ** instead of struct page *.
> - move functions to the place before relay_mmap_buf.
> - add comments.
>
> This is useful for a 64-bit system which has a plenty of memory (tens of
> giga bytes) and a large kernel memory space.
>
> I tested it on x86-64 and ia64.
>
Hi,
Looks fine to me.
Reviewed-by: Tom Zanussi <tzanussi@gmail.com>