This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 1/1] x86: fix text_poke
- From: Arnaldo Carvalho de Melo <acme at redhat dot com>
- To: Jeremy Fitzhardinge <jeremy at goop dot org>
- Cc: Masami Hiramatsu <mhiramat at redhat dot com>, Mathieu Desnoyers <mathieu dot desnoyers at polymtl dot ca>, Linus Torvalds <torvalds at linux-foundation dot org>, "H. Peter Anvin" <hpa at zytor dot com>, Andi Kleen <andi at firstfloor dot org>, Ingo Molnar <mingo at elte dot hu>, Jiri Slaby <jirislaby at gmail dot com>, David Miller <davem at davemloft dot net>, zdenek dot kabelac at gmail dot com, rjw at sisk dot pl, paulmck at linux dot vnet dot ibm dot com, akpm at linux-foundation dot org, linux-ext4 at vger dot kernel dot org, herbert at gondor dot apana dot org dot au, penberg at cs dot helsinki dot fi, clameter at sgi dot com, linux-kernel at vger dot kernel dot org, pageexec at freemail dot hu, "Frank Ch. Eigler" <fche at redhat dot com>, systemtap at sources dot redhat dot com
- Date: Sat, 26 Apr 2008 08:56:34 -0300
- Subject: Re: [PATCH 1/1] x86: fix text_poke
- References: <48123C9B.9020306@zytor.com> <20080425203717.GB25950@Krystal> <481241DC.3070601@zytor.com> <alpine.LFD.1.10.0804251349510.2779@woody.linux-foundation.org> <20080425211205.GC25950@Krystal> <alpine.LFD.1.10.0804251456410.2779@woody.linux-foundation.org> <20080425230028.GC31226@Krystal> <481265B7.9040505@goop.org> <48126A80.4000203@redhat.com> <4812CA02.8040705@goop.org>
Em Fri, Apr 25, 2008 at 11:21:54PM -0700, Jeremy Fitzhardinge escreveu:
> Masami Hiramatsu wrote:
>> Jeremy Fitzhardinge wrote:
>>
>>> Mathieu Desnoyers wrote:
>>>
>>>> This idea has been considered a few years ago at OLS in the tracing BOF
>>>> if I remember well. The results were this : First, there is no way to
>>>> guarantee that no code path, nor any return address from any function,
>>>> interrupt, sleeping thread, will return to the "old" version of the
>>>> function. Nor is it possible to determine when a quiescent state is
>>>> reached. Therefore, we couldn't see how we can do the teardown.
>>>>
>>> Does that matter? The new function is semantically identical to the old
>>> one, and the old code will remain in place. If there's still users in
>>> the old function it may take a while for them to get flushed out (and
>>> won't be traced in the meantime), but you have to expect some missed
>>> events if you're shoving any kind of dynamic marker into the code. The
>>> main problem is if there's something still depending on the first 5 bytes
>>> of the function (most likely if there's a loop head somewhere near the
>>> top of the function).
>>>
>>
>> I think we have to ensure no threads sleeping or being interrupted on
>> the function when removing new function. How would you check it?
>>
>
> Not sure I follow you. You'd never remove any code. But you'd only start
You do, when you decide to stop tracing. He is not talking about the old
function, that one, indeed will always be there, but what about the new
one? When tracing stops we want to remove it and revert to using the old
one...
But perhaps you are suggesting that the new one, once loaded, stays
there forever, that would work, but after several tracing sessions one
would have to eventually reboot the machine due to many modules left
loaded.
- Arnaldo