This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [patch] Bug #5001 - ctime() vs _stp_ctime() duplication
- From: Mark Wielaard <mwielaard at redhat dot com>
- To: systemtap at sources dot redhat dot com
- Date: Wed, 21 May 2008 13:23:39 +0200
- Subject: Re: [patch] Bug #5001 - ctime() vs _stp_ctime() duplication
- References: <1211313262.3284.74.camel@dijkstra.wildebeest.org>
Hi,
On Tue, 2008-05-20 at 21:54 +0200, Mark Wielaard wrote:
> tapset/ChangeLog
> 2008-05-20 Mark Wielaard <mwielaard@redhat.com>
>
> PR 5001
> * aux_syscalls.stp (_stp_ctime): Removed.
> (_struct_utimbuf_u): Removed.
> (_struct_compat_utimbuf_u): Removed.
> (_struct_utimbuf_actime): New function.
> (_struct_utimbuf_modtime): New function.
> (_struct_compat_utimbuf_actime): New function.
> (_struct_compat_utimbuf_modtime): New function.
> * syscalls2.stp (syscall.utime): Use new functions and ctime.
> (syscall.compat_utime): Likewise.
>
> testsuite/ChangeLog
> 2008-05-20 Mark Wielaard <mwielaard@redhat.com>
>
> PR 5001
> * systemtap.syscall/futimes.c (utime): Expect new time format.
> * systemtap.syscall/stat.c (utime): Likewise.
I should have run the full installcheck testsuite before committing and
pushing. There was a regression in buildok/aux_syscalls-embedded.stp.
Fixed as follows:
2008-05-21 Mark Wielaard <mwielaard@redhat.com>
* buildok/aux_syscalls-embedded.stp: Don't check _struct_utimbuf_u
and _struct_compat_utimbuf_u. Check new _struct_utimbuf_actime,
_struct_utimbuf_modtime, _struct_compat_utimbuf_actime and
_struct_compat_utimbuf_modtime.
Apologies,
Mark
diff --git a/testsuite/buildok/aux_syscalls-embedded.stp
b/testsuite/buildok/aux
index 2b55280..ce00893 100755
--- a/testsuite/buildok/aux_syscalls-embedded.stp
+++ b/testsuite/buildok/aux_syscalls-embedded.stp
@@ -4,8 +4,10 @@ probe begin {
print (_struct_timeval_u(0,0))
print (_struct_compat_timeval_u(0,0))
print (_struct_timezone_u (0))
- print (_struct_utimbuf_u(0))
- print (_struct_compat_utimbuf_u(0))
+ print (_struct_utimbuf_actime(0))
+ print (_struct_utimbuf_modtime(0))
+ print (_struct_compat_utimbuf_actime(0))
+ print (_struct_compat_utimbuf_modtime(0))
print (_struct_timespec_u(0,0))
print (_struct_compat_timespec_u(0,0))
print (_struct_itimerspec_u(0))