This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] instruction tracing probe
- From: David Smith <dsmith at redhat dot com>
- To: Dave Nomura <dcnltc at us dot ibm dot com>
- Cc: systemtap at sourceware dot org
- Date: Mon, 30 Jun 2008 15:13:12 -0500
- Subject: Re: [PATCH] instruction tracing probe
- References: <4868220A.7050507@us.ibm.com>
Dave Nomura wrote:
> This patch set implements user space instruction tracing by the
> following itrace probe:
...
Based on a quick reading of the code, it looks reasonable to me. It is
missing a few things (that shouldn't keep you from checking it in) like
testcases and additions to the man pages.
We probably should also look at places where we could share more code
between the itrace and utrace probes (such as when validating pathnames).
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)