This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 3/3] PR4886: Check build-id in module_init function if able.
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: wenji dot huang at oracle dot com
- Cc: SystemTAP <systemtap at sources dot redhat dot com>
- Date: Sun, 28 Sep 2008 09:36:44 -0400
- Subject: Re: [PATCH 3/3] PR4886: Check build-id in module_init function if able.
- References: <48DEEA31.9010004@oracle.com>
Hi, Wenji -
Excellent work. If it passes regression tests, please check it in.
It shouldn't be hard to apply it to userspace too, if it doesn't
already just work.
Some tweaks to the various messages may be helpful later, such as to
print parts of the buildid strings for eyeballing by the user, but
otherwise it looks just fine.
- FChE