This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] markers: fix missing modpost entry in Module.markers
- From: KOSAKI Motohiro <kosaki dot motohiro at jp dot fujitsu dot com>
- To: Lai Jiangshan <laijs at cn dot fujitsu dot com>
- Cc: kosaki dot motohiro at jp dot fujitsu dot com, Andrew Morton <akpm at linux-foundation dot org>, Greg KH <gregkh at suse dot de>, stable at kernel dot org, Linux Kernel Mailing List <linux-kernel at vger dot kernel dot org>, Mathieu Desnoyers <mathieu dot desnoyers at polymtl dot ca>, Roland McGrath <roland at redhat dot com>, Wenji Huang <wenji dot huang at oracle dot com>, Takashi Nishiie <t-nishiie at np dot css dot fujitsu dot com>, systemtap at sourceware dot org
- Date: Tue, 7 Oct 2008 15:51:34 +0900 (JST)
- Subject: Re: [PATCH] markers: fix missing modpost entry in Module.markers
- References: <48EB032B.3070200@cn.fujitsu.com>
Hi Lai
Have you seen "Markers in (non-module) kernel code?" thread?
I think this patch and that patch treat the same issue.
In addition, I think mathieu's patch is better.
So, Could I hear your opinition for that?
>
> commit d35cb360c29956510b2fe1a953bd4968536f7216 brought a bug.
> marker points compiled in vmlinux are missing in Module.markers.
>
> # cat Module.markers
> subsystem_event samples/markers/marker-example integer %d string %s
> subsystem_eventb samples/markers/marker-example
>
> # stap -e 'probe kernel.mark("core_marker_format"){} '
> semantic error: no match while resolving probe point kernel.mark("core_marker_format")
> semantic error: no probes found
> Pass 2: analysis failed. Try again with more '-v' (verbose) options.
>
> This patch revert a part of d35cb360c29956510b2fe1a953bd4968536f7216.
> Other parts have fixed duplicate modpost entry bug.
>
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 418cd7d..3509142 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -1992,8 +1992,7 @@ static void read_markers(const char *fname)
> mod->skip = 1;
> }
>
> - if (!mod->skip)
> - add_marker(mod, marker, fmt);
> + add_marker(mod, marker, fmt);
> }
> return;
> fail:
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/