This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -rc] [BUGFIX] x86: fix kernel_trap_sp()
- From: Linus Torvalds <torvalds at linux-foundation dot org>
- To: Robin Holt <holt at sgi dot com>
- Cc: Masami Hiramatsu <mhiramat at redhat dot com>, LKML <linux-kernel at vger dot kernel dot org>, systemtap at sources dot redhat dot com, Harvey Harrison <harvey dot harrison at gmail dot com>, Ingo Molnar <mingo at elte dot hu>, Thomas Gleixner <tglx at linutronix dot de>, Jan Blunck <jblunck at suse dot de>, Christoph Hellwig <hch at infradead dot org>
- Date: Tue, 12 May 2009 07:36:07 -0700 (PDT)
- Subject: Re: [PATCH -rc] [BUGFIX] x86: fix kernel_trap_sp()
- References: <20090511210300.17332.67549.stgit@localhost.localdomain> <alpine.LFD.2.01.0905111512240.3586@localhost.localdomain> <20090512112300.GL7601@sgi.com>
On Tue, 12 May 2009, Robin Holt wrote:
> > */
> > -static inline unsigned long kernel_trap_sp(struct pt_regs *regs)
> > +static inline unsigned long kernel_stack_pointer(struct pt_regs *regs)
>
> Why not have it return an unsigned long *?
I considered it, but since part of the point of the patch was to make it
look like the mirror of "user_stack_pointer()", returning "unsigned long"
looked more appropriate.
But I have no really strong opinions. I wouldn't object to making it
return "unsigned long *" either.
Linus