This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Correct misnamed and remove superfluous variables in syscalls.stp.


In syscall.(faccess|fchmod|fchown|link|mknod)at probe points:
- Rename variables accordingly to argument names used in man pages.
- Remove string-formatted integer variables.
---
 tapset/syscalls.stp |   57 ++++++++++++++++++--------------------------------
 1 files changed, 21 insertions(+), 36 deletions(-)

diff --git a/tapset/syscalls.stp b/tapset/syscalls.stp
index 0eaf84c..aa265cd 100644
--- a/tapset/syscalls.stp
+++ b/tapset/syscalls.stp
@@ -712,13 +712,11 @@ probe syscall.exit_group = kernel.function("SyS_exit_group") !,
 probe syscall.faccessat = kernel.function("SyS_faccessat") !,
 		kernel.function("sys_faccessat") ? {
 	name = "faccessat"
-	dfd = $dfd
-	dfd_str = _dfd_str($dfd)
-	filename = $filename
-	filename_str = user_string($filename)
+	dirfd = $dfd
+	pathname = user_string($filename)
 	mode = $mode
 	mode_str = _access_mode_str($mode)
-	argstr = sprintf("%s, %s, %s", dfd_str, user_string_quoted($filename), mode_str)
+	argstr = sprintf("%s, %s, %s", _dfd_str($dfd), user_string_quoted($filename), mode_str)
 }
 probe syscall.faccessat.return = kernel.function("SyS_faccessat").return !,
 		kernel.function("sys_faccessat").return ? {
@@ -838,12 +836,10 @@ probe syscall.fchmod.return = kernel.function("SyS_fchmod").return !,
 probe syscall.fchmodat = kernel.function("SyS_fchmodat") !,
 		kernel.function("sys_fchmodat") ? {
 	name = "fchmodat"
-	dfd = $dfd
-	dfd_str = _dfd_str($dfd)
-	filename = $filename
-	filename_str = user_string($filename)
+	dirfd = $dfd
+	pathname = user_string($filename)
 	mode = $mode
-	argstr = sprintf("%s, %s, %#o", dfd_str, user_string_quoted($filename), $mode)
+	argstr = sprintf("%s, %s, %#o", _dfd_str($dfd), user_string_quoted($filename), $mode)
 }
 probe syscall.fchmodat.return = kernel.function("SyS_fchmodat").return !,
 		kernel.function("sys_fchmodat").return ? {
@@ -888,16 +884,13 @@ probe syscall.fchown16.return = kernel.function("sys_fchown16").return ? {
 probe syscall.fchownat = kernel.function("SyS_fchownat") !,
 		kernel.function("sys_fchownat") ? {
 	name = "fchownat"
-	dfd = $dfd
-	dfd_str = _dfd_str($dfd)
-	filename = $filename
-	filename_str = user_string($filename)
-	user = __int32($user)
+	dirfd = $dfd
+	pathname = user_string($filename)
+	owner = __int32($user)
 	group = __int32($group)
-	flag = $flag
-	flag_str = _at_flag_str($flag)
+	flags = $flag
 	argstr = sprintf("%s, %s, %d, %d, %s",
-		dfd_str, user_string_quoted($filename), user, group, flag_str)
+		_dfd_str($dfd), user_string_quoted($filename), owner, group, _at_flag_str($flag))
 }
 probe syscall.fchownat.return = kernel.function("SyS_fchownat").return !,
 		kernel.function("sys_fchownat").return ? {
@@ -2332,20 +2325,15 @@ probe syscall.link.return = kernel.function("SyS_link").return !,
 probe syscall.linkat = kernel.function("SyS_linkat") !,
 		kernel.function("sys_linkat") ? {
 	name = "linkat"
-	olddfd = $olddfd
-	olddfd_str = _dfd_str($olddfd)
-	oldname = $oldname
-	oldname_str = user_string($oldname)
-	newdfd = $newdfd
-	newdfd_str = _dfd_str($newdfd)
-	newname = $newname
-	newname_str = user_string($newname)
+	olddirfd = $olddfd
+	oldpath = user_string($oldname)
+	newdirfd = $newdfd
+	newpath = user_string($newname)
 	flags = $flags
-	flags_str = _at_flag_str($flags)
 	argstr = sprintf("%s, %s, %s, %s, %s",
-		olddfd_str, user_string_quoted($oldname),
-		newdfd_str, user_string_quoted($newname),
-		flags_str)
+		_dfd_str($olddfd), user_string_quoted($oldname),
+		_dfd_str($newdfd), user_string_quoted($newname),
+		_at_flag_str($flags))
 }
 probe syscall.linkat.return = kernel.function("SyS_linkat").return !,
 		kernel.function("sys_linkat").return ? {
@@ -2720,15 +2708,12 @@ probe syscall.mknod.return = kernel.function("SyS_mknod").return !,
 probe syscall.mknodat = kernel.function("SyS_mknodat") !,
 		kernel.function("sys_mknodat") ? {
 	name = "mknodat"
-	dfd = $dfd
-	dfd_str = _dfd_str($dfd)
-	filename = $filename
-	filename_str = user_string($filename)
+	dirfd = $dfd
+	pathname = user_string($filename)
 	mode = $mode
-	mode_str = _mknod_mode_str($mode)
 	dev = $dev
 	argstr = sprintf("%s, %s, %s, %p",
-		dfd_str, user_string_quoted($filename), mode_str, $dev)
+		_dfd_str($dfd), user_string_quoted($filename), _mknod_mode_str($mode), $dev)
 }
 probe syscall.mknodat.return = kernel.function("SyS_mknodat").return !,
 		kernel.function("sys_mknodat").return ? {
-- 
1.5.6.5


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]