This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v6 1/5] x86: instruction decorder API
- From: Masami Hiramatsu <mhiramat at redhat dot com>
- To: "H. Peter Anvin" <hpa at zytor dot com>
- Cc: PrzemysÅaw PaweÅczyk <przemyslaw at pawelczyk dot it>, Ingo Molnar <mingo at elte dot hu>, Steven Rostedt <rostedt at goodmis dot org>, lkml <linux-kernel at vger dot kernel dot org>, systemtap <systemtap at sources dot redhat dot com>, kvm <kvm at vger dot kernel dot org>, DLE <dle-develop at lists dot sourceforge dot net>, Jim Keniston <jkenisto at us dot ibm dot com>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Frederic Weisbecker <fweisbec at gmail dot com>, Andi Kleen <ak at linux dot intel dot com>, Vegard Nossum <vegard dot nossum at gmail dot com>, Avi Kivity <avi at redhat dot com>
- Date: Thu, 21 May 2009 11:52:05 -0400
- Subject: Re: [PATCH -tip v6 1/5] x86: instruction decorder API
- References: <20090520205758.25003.44632.stgit@localhost.localdomain> <20090520205805.25003.71314.stgit@localhost.localdomain> <40e92d5b0905201501i1548621xe1ee63aa88129a0@mail.gmail.com> <4A1488A2.30706@redhat.com> <4A14EA86.2060609@zytor.com>
H. Peter Anvin wrote:
> Masami Hiramatsu wrote:
>>> /usr/bin/env 'awk -f' gen-insn-attr-x86.awk
>>>
>>> which is obviously wrong.
>> Oops, right. Anyway, there is no reason that we make it
>> executable because it's always called from Makefile.
>> So, I think just removing that line is better way.
>>
>
> I suggest leaving in a #!/bin/awk line just for documentation's sake,
> though.
OK, I'd leave that, and change usage line to use awk command
instead of run the script directly.
Thank you!
>
> -hpa
>
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com