This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug uprobes/10595] uprobe probes causes selinux failures


------- Additional Comments From jkenisto at us dot ibm dot com  2009-09-04 17:11 -------
(In reply to comment #5)
> Created an attachment (id=4170)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4170&action=view)
> ssol-vma-selinux patch using shmem_file_setup

At this point
       if (addr & ~PAGE_MASK) {
addr will be undefined if shmem_file_setup() returned NULL.  So...
       if (!file || (addr & ~PAGE_MASK)) {

> 
> This is the patch that seems to work fine for me. I added some comments and
> some error messages in case something fails. This is against uprobes2, I assume
> uprobes1 needs a similar fix. Is the systemtap version where these should go,
> or is there another upstream for uprobes now?

Yes, runtime/uprobes/uprobes.c and ubp_xol.c (?) in the ubp-based uprobes bits.
 Thanks, mjw.  Srikar, are you going to take it from here?

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10595

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]