This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] Create a function that indents without the tid()
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: Breno Leitao <leitao at linux dot vnet dot ibm dot com>
- Cc: systemtap at sources dot redhat dot com
- Date: Wed, 30 Sep 2009 15:14:56 -0400
- Subject: Re: [PATCH] Create a function that indents without the tid()
- References: <4AC39EFA.50407@linux.vnet.ibm.com>
Breno Leitao <leitao@linux.vnet.ibm.com> writes:
> Actually indent_thread() is a very useful function, but
> sometimes you're probing something that is not related to
> thread, as an interrupt function, and if the application
> changes during the interrupt, the indentation gets confused.
> [...]
It gets a bit confusing to read, but it is correct in several senses.
(I wonder what ftrace pretty-printed function traces with SMP look
like.)
> [...]
> So, I decided to create a simpler function that doesn't
> consider the thread.
> +function indent(delta){
> + _indent += delta
> + for (i=1; i<_indent; i++) r .= " "
> + return r
> +}
Perhaps, but why not just
function indent(delta) { return _generic_indent(0, delta) }
?
- FChE